A vBulletin site devoted to helping webmaster optimize their search results in search engines.
Please welcome our newest member, gunnaracm!
Spice up your web site with the ultimate community message board solution!
Fake Id'sGet fake Id's made right now!
vBSEOSearch Engine Optimization for your VBulletin Forum.
AdminFusion
»
babbleboard - new and cool looking forum software
| | #31 |
| | ||||||
| Title: Member Join Date: Apr 2006 Posts: 70 Location: Cincinnati, Ohio ![]() | Here's the number one reason why I wouldn't use it: Quote:
While I do see some improvements, some other things I mentioned last time still haven't been addressed: Messy queries Sloppy code - line spacing and indentation seems to be random at best Hard-coded language strings Two lines of code where only one is required (you can set a variable AND escape the value in one line) Relying on glob() to find attachments and thumbnails for deletion (the forum should know the EXACT name of the file it wants to delete) Password-encryption stuff leaves a lot to be desired: You don't bother looking for hash, so md5 will be used on many servers even though sha256 is available Your method for detecting mhash is ridiculous (hint: function_exists()...) I honestly don't see a need for such a ridiculous method of password encryption to begin with. If you're going to use sha256, then just add some sort of "salt" to the password and use the sha256 hash without bin2hex or base64 encoding (do you really need a 172-character password hash?). If you still insist on using sha256, then your script should not install if it isn't available. Right now it only checks the password based on what method the server currently supports without checking the other method. This will result in all users having to reset their passwords in numerous cases (since the script currently doesn't support hash(), if PHP is upgraded, it reverts to md5 encryption; if the script was installed when mhash wasn't available, but mhash is now available, the script uses the fancy sha256 stuff...). Other issues: glob() did not exist until PHP 4.3.0 stristr() doesn't exist in PHP 4.x MySQL 4.0.x did not support character sets or the ENGINE keyword (in that version, TYPE was used instead of ENGINE).
__________________ The Oldiesmann SMF Project Manager SMF+Gallery2 Integration Project - Beta3.1 now available! | |||||
| |
| | #32 |
| | |||||
| Title: Member Join Date: Apr 2006 Posts: 70 Location: Cincinnati, Ohio ![]() | One other thing I forgot to mention in my last post. You don't have anything on your site or your forum mentioning how someone can become a supporter, how much it costs, what the payment options are, etc. If you want to attract people to that program, you're going to need to provide them with that info.
__________________ The Oldiesmann SMF Project Manager SMF+Gallery2 Integration Project - Beta3.1 now available! | ||||
| |
| | #33 |
| | ||||||
|
Title: Back in the Green Join Date: Feb 2006 Posts: 753 Location: Scotland ![]() ![]() ![]() | Quote:
__________________ Bob's Bit of the Web Into Blogging? Want to talk about it or need help with something? Join us at the Blogging Café. | |||||
| |
| | #34 |
| | #35 |
| | ||||||
| Title: Member Join Date: Apr 2006 Posts: 70 Location: Cincinnati, Ohio ![]() | Quote:
__________________ The Oldiesmann SMF Project Manager SMF+Gallery2 Integration Project - Beta3.1 now available! | |||||
| |
| | #36 |
| | #37 |
| | |||||
|
Title: Super Moderator Join Date: Feb 2007 Posts: 1,269 Location: Gainesville, FL ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() | Yes. I wish everyone would use Fire Fox (numbers are growing quickly) I told all members on my board to get it as they would like it better... but unfortunately, the majority of internet users are still on IE 6 as my stats from google analytics state. The numbers may be different here on Admin help type board as most of us know more about choices but you can't block out the majority of users because of .png issue. As stated above, there is a fix for it which I wasn't aware of until now. Thanks for the link! | ||||
| |
| | #38 |
| | ||||||
|
Title: Forum Addict Join Date: Nov 2005 Posts: 1,355 Location: United Kingdom ![]() | Quote:
Yes i know this will never happen... ![]() And that is a rather dumb move to drop support for IE6 to support transparent PNG images, as they are cutting allot of potential customers. They should offer support for both. Last edited by Flashgear; 10-24-2007 at 02:45 PM. Reason: Adding Final Comment | |||||
| |
| | #39 |
